KM-4856: Fix DIP on tvOS due to Accounts migrations#164
Merged
kp-said-rehouni merged 1 commit intomasterfrom Jul 12, 2024
Merged
KM-4856: Fix DIP on tvOS due to Accounts migrations#164kp-said-rehouni merged 1 commit intomasterfrom
kp-said-rehouni merged 1 commit intomasterfrom
Conversation
kp-said-rehouni
force-pushed
the
KM-4856_fix_dip_tvos
branch
from
962914f to
666b404
Compare
kp-said-rehouni
force-pushed
the
KM-4856_fix_dip_tvos
branch
2 times, most recently
from
9b54659 to
8cfa4f9
Compare
kp-said-rehouni
force-pushed
the
KM-4856_fix_dip_tvos
branch
from
8cfa4f9 to
d311e15
Compare
kp-laura-sempere
approved these changes
Jul 12, 2024
Collaborator
kp-laura-sempere
left a comment
kp-laura-sempere
left a comment
There was a problem hiding this comment.
Great job @kp-said-rehouni !
✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the DIP issue after migrating the Accounts screen by using the same
DefaultServerProviderinstance across the app. By using one single instance, we guarantee that we use the same Keychain instance as well which is required to save and fetch the dip token.